Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: datagrid action pause flake #9802

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

JComins000
Copy link
Contributor

@JComins000 JComins000 commented Aug 6, 2024

Ticket

Description

increasing the timeout seems to have worked here. check this thread

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@JComins000 JComins000 requested a review from a team as a code owner August 6, 2024 18:08
@cla-bot cla-bot bot added the cla-signed label Aug 6, 2024
Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 73fb747
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66b27e910835010008afd1d0
😎 Deploy Preview https://deploy-preview-9802--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.08%. Comparing base (8173cab) to head (73fb747).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9802      +/-   ##
==========================================
- Coverage   54.33%   50.08%   -4.25%     
==========================================
  Files        1261      938     -323     
  Lines      155622   126289   -29333     
  Branches     3534     3533       -1     
==========================================
- Hits        84560    63258   -21302     
+ Misses      70924    62893    -8031     
  Partials      138      138              
Flag Coverage Δ
harness ?
web 53.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 323 files with indirect coverage changes

@JComins000 JComins000 force-pushed the jcom/no-issue/dataaction-pause-test branch from aa3f43d to a71ba23 Compare August 6, 2024 19:49
@JComins000 JComins000 force-pushed the jcom/no-issue/dataaction-pause-test branch from a71ba23 to 73fb747 Compare August 6, 2024 19:50
@JComins000 JComins000 merged commit d3f3e76 into main Aug 6, 2024
82 of 95 checks passed
@JComins000 JComins000 deleted the jcom/no-issue/dataaction-pause-test branch August 6, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants